🎨 Palette: Accessible Anchor Buttons#137
Conversation
- Adds `role="button"` and `aria-haspopup="dialog"` to all "OSINT" `<a>` tags (`#sitrep-btn`). - Adds a missing `#sitrep-btn` link to `index.html`'s navigation for consistency. - Binds a `Spacebar` keyboard event listener in `modal.js` so the links behave exactly like native buttons, preventing default scrolling and opening the modal. - Logs the structural learning in `.Jules/palette.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added proper semantic attributes (
role="button",aria-haspopup="dialog") and a JavaScript spacebar event handler to the "OSINT" anchor tags (#sitrep-btn) across the site. Also added the missing link to theindex.htmlnavbar.🎯 Why: Anchor tags (
<a>withhref="#") used to trigger modals break accessibility expectations. Native anchors trigger onEnterbut not onSpace(which just scrolls the page), and screen readers announce them as links instead of actionable buttons.📸 Before/After: Visually identical. A screenshot of the modal successfully opening has been provided in the pre-commit checks.
♿ Accessibility: Screen readers will now correctly announce the link as a button that opens a dialog. Keyboard users can now intuitively trigger the modal using the Spacebar without the page suddenly scrolling away.
PR created automatically by Jules for task 9816705825757504987 started by @0m364