🎨 Palette: Improve accessibility of anchor buttons for modals#134
Conversation
💡 What: Added `role="button"` and `aria-haspopup="dialog"` to native `<a>` tags used as buttons, and explicitly bound the Spacebar key to the action to prevent page scrolling. 🎯 Why: Native `<a>` tags only respond to `Enter`. Screen reader and keyboard users expect elements functioning as buttons to also trigger on `Spacebar`. Defaulting to scroll creates a confusing experience. 📸 Before/After: Visuals remain unchanged, but the element now correctly responds to Spacebar without scrolling. ♿ Accessibility: Ensures correct ARIA semantic roles and restores standard keyboard expectations for interactive elements.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
role="button"andaria-haspopup="dialog"to native<a>tags used as buttons, and explicitly bound the Spacebar key to the action to prevent page scrolling.🎯 Why: Native
<a>tags only respond toEnter. Screen reader and keyboard users expect elements functioning as buttons to also trigger onSpacebar. Defaulting to scroll creates a confusing experience.📸 Before/After: Visuals remain unchanged, but the element now correctly responds to Spacebar without scrolling.
♿ Accessibility: Ensures correct ARIA semantic roles and restores standard keyboard expectations for interactive elements.
PR created automatically by Jules for task 429815404078661445 started by @0m364