🎨 Palette: Add keyboard spacebar and semantic roles to anchor buttons#133
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Updated
#sitrep-btnanchor tags across all HTML files to includerole="button"andaria-haspopup="dialog". Also bound akeydownevent inmodal.jsto ensure the Spacebar triggers the modal properly while preventing default scrolling behavior.🎯 Why: Native HTML anchor tags (
<a href="#">) behave like links instead of buttons to screen readers, and do not natively respond to theSpacebarkey for interaction. This ensures keyboard and screen reader users can predictably trigger the modal.📸 Before/After: Visuals remain unchanged. A Playwright test in
test_ui.pyhas been added to prove keyboard accessibility.♿ Accessibility: Ensures semantic correctness (
role="button") and standard keyboard interactivity (Spacebar support) for links used exclusively as UI triggers.PR created automatically by Jules for task 5742326161916662310 started by @0m364