🎨 Palette: [Anchor Tag as Button Accessibility]#132
Conversation
Added `role="button"` and `aria-haspopup="dialog"` to the `a#sitrep-btn` tags across the site and implemented spacebar activation in `modal.js` to ensure the link properly behaves like a native button for keyboard users.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added
role="button"andaria-haspopup="dialog"to all instances of<a href="#" id="sitrep-btn">. Added akeydownlistener for theSpacebarto trigger theopenModalfunction, mirroring native button behavior. Recorded a new learning entry in.Jules/palette.md.🎯 Why:
Using anchor tags with
#hrefs to trigger actions (rather than navigate) creates an accessibility mismatch. Screen readers announce them as links, and keyboard users can only trigger them withEnter. Adding the correct ARIA attributes and Spacebar support ensures they behave as expected for all users.📸 Before/After:
Before, the button was only triggered via click or
Enter. Now, it can also be triggered viaSpacewhich is the standard expected behavior for buttons.♿ Accessibility:
Improved keyboard navigation and screen reader semantics by appropriately defining the role and adding expected keyboard interaction support for links that function as buttons.
PR created automatically by Jules for task 12734702187814607320 started by @0m364