🎨 Palette: Improve accessibility and keyboard support for modal triggers#131
Conversation
- Added `role="button"` and `aria-haspopup="dialog"` to `#sitrep-btn` anchor tags in `concepts.html`, `contact.html`, and `products.html`. - Added a `keydown` listener in `modal.js` to open the modal and prevent default page scrolling when the `Space` key is pressed. - Added a new UI test in `test_ui.py` to verify modal trigger ARIA attributes and keyboard functionality. - Logged the learning in `.Jules/palette.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
Added proper ARIA roles (
role="button",aria-haspopup="dialog") andSpacebarkeyboard support to the OSINT modal triggers across the site.🎯 Why:
The OSINT modal trigger used anchor
<a>tags withhref="#". Native anchor tags only trigger on theEnterkey and are announced as links by screen readers. By adding button roles and spacebar support, it now behaves like a native button, providing a predictable and accessible experience for screen reader and keyboard-only users.📸 Before/After:
(No visual changes - purely an under-the-hood accessibility and keyboard interaction improvement.)
♿ Accessibility:
Spacekey, matching standard button behavior and preventing default page scrolling.PR created automatically by Jules for task 5106985375778910046 started by @0m364