🎨 Palette: Add ARIA button roles and Spacebar support to modal triggers#130
Conversation
- Added `role="button"` and `aria-haspopup="dialog"` to `#sitrep-btn` links. - Implemented `Space` and `Spacebar` key support to open the modal without page scrolling. - Recorded the learning log in `.Jules/palette.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
role="button"andaria-haspopup="dialog"to all<a href="#">tags acting as buttons for the "Sitrep" modal. Handledkeydownevents for theSpacekey to open the modal properly.🎯 Why: Anchor tags (
<a>withhref="#") lack inherent button semantics. Screen readers might misinterpret their role, and they don't natively trigger with theSpacekey, disrupting the expected keyboard navigation flow.📸 Before/After: Visual presentation is identical. Non-visual usage (screen readers, keyboard-only access) is highly improved.
♿ Accessibility: Ensures that keyboard-only users and screen readers understand that the Sitrep links act as buttons opening dialogs. It fully mimics native button behavior across interactions.
PR created automatically by Jules for task 2348731864699853036 started by @0m364