Skip to content

🎨 Palette: Add keyboard accessibility and ARIA roles to OSINT modal triggers#129

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-osint-modal-a11y-8748266971196831645
Open

🎨 Palette: Add keyboard accessibility and ARIA roles to OSINT modal triggers#129
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-osint-modal-a11y-8748266971196831645

Conversation

@0m364

@0m364 0m364 commented Jun 29, 2026

Copy link
Copy Markdown
Owner

💡 What: Added role="button" and aria-haspopup="dialog" to the anchor tags (#sitrep-btn) used to open the OSINT modal. Updated modal.js to listen for the Spacebar keypress to trigger the modal and prevent default page scrolling.

🎯 Why: Using <a> tags (with href="#") to trigger modals without native button semantics creates a poor experience for screen readers and keyboard users. Native anchors only trigger on Enter, whereas users expect buttons to respond to Spacebar as well. Without proper ARIA roles, assistive tech reads them as simple links instead of dialog triggers.

📸 Before/After: Visually identical, but functionally accessible via keyboard (Spacebar).

Accessibility: Screen readers now correctly identify the links as buttons that open a dialog. Keyboard users can now use both Enter (native) and Spacebar (custom listener) to interact with the triggers as expected of interactive buttons. Recorded this learning pattern in .Jules/palette.md.


PR created automatically by Jules for task 8748266971196831645 started by @0m364

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant