🎨 Palette: Add keyboard accessibility and ARIA roles to OSINT modal triggers#129
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
role="button"andaria-haspopup="dialog"to the anchor tags (#sitrep-btn) used to open the OSINT modal. Updatedmodal.jsto listen for theSpacebarkeypress to trigger the modal and prevent default page scrolling.🎯 Why: Using
<a>tags (withhref="#") to trigger modals without native button semantics creates a poor experience for screen readers and keyboard users. Native anchors only trigger onEnter, whereas users expect buttons to respond toSpacebaras well. Without proper ARIA roles, assistive tech reads them as simple links instead of dialog triggers.📸 Before/After: Visually identical, but functionally accessible via keyboard (Spacebar).
♿ Accessibility: Screen readers now correctly identify the links as buttons that open a dialog. Keyboard users can now use both Enter (native) and Spacebar (custom listener) to interact with the triggers as expected of interactive buttons. Recorded this learning pattern in
.Jules/palette.md.PR created automatically by Jules for task 8748266971196831645 started by @0m364