🎨 Palette: Accessible Anchor Buttons#128
Conversation
Added `role="button"` and `aria-haspopup="dialog"` to all OSINT anchor tags that act as modal buttons to improve screen reader semantic meaning. Also added a `keydown` listener for the Spacebar in `modal.js` to ensure the link triggers like a real button for keyboard users.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added semantic roles and keyboard behavior to anchor tags (
<a href="#">) being used as buttons for opening the OSINT modal.🎯 Why: Screen readers previously announced these buttons as generic "links", causing confusion. Furthermore, keyboard-only users expect buttons to activate with the Spacebar, but default links only trigger on Enter. Pressing Spacebar previously caused unwanted page scrolling.
📸 Before/After: No visual changes. Behavior and semantics updated.
♿ Accessibility:
role="button"andaria-haspopup="dialog"to the#sitrep-btnanchors to correctly identify them as dialog triggers.Spacebarkey to trigger theopenModalaction while preventing default scroll behavior, matching native<button>functionality.PR created automatically by Jules for task 2790979982845554396 started by @0m364