Skip to content

🎨 Palette: Accessible Anchor Buttons#128

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
fix-anchor-button-a11y-2790979982845554396
Open

🎨 Palette: Accessible Anchor Buttons#128
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
fix-anchor-button-a11y-2790979982845554396

Conversation

@0m364

@0m364 0m364 commented Jun 28, 2026

Copy link
Copy Markdown
Owner

💡 What: Added semantic roles and keyboard behavior to anchor tags (<a href="#">) being used as buttons for opening the OSINT modal.

🎯 Why: Screen readers previously announced these buttons as generic "links", causing confusion. Furthermore, keyboard-only users expect buttons to activate with the Spacebar, but default links only trigger on Enter. Pressing Spacebar previously caused unwanted page scrolling.

📸 Before/After: No visual changes. Behavior and semantics updated.

Accessibility:

  • Added role="button" and aria-haspopup="dialog" to the #sitrep-btn anchors to correctly identify them as dialog triggers.
  • Mapped the Spacebar key to trigger the openModal action while preventing default scroll behavior, matching native <button> functionality.

PR created automatically by Jules for task 2790979982845554396 started by @0m364

Added `role="button"` and `aria-haspopup="dialog"` to all OSINT anchor tags that act as modal buttons to improve screen reader semantic meaning. Also added a `keydown` listener for the Spacebar in `modal.js` to ensure the link triggers like a real button for keyboard users.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant