🎨 Palette: Make anchor-based modal buttons accessible to keyboard users#127
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
role="button"andaria-haspopup="dialog"to the#sitrep-btnanchor tags across HTML files, and implemented akeydownlistener inmodal.jsto trigger the modal via theSpacebar.🎯 Why: To ensure semantic correctness and provide keyboard functionality parity. Anchor tags natively only trigger on the
Enterkey, while screen reader and keyboard users expect interactive 'buttons' to respond to theSpacebaras well.📸 Before/After: No visual change.
♿ Accessibility: Users navigating via keyboard can now predictably activate the "OSINT" modal using the
Spacebar, and screen readers will correctly announce the element as a button rather than a link.PR created automatically by Jules for task 5315420440353117592 started by @0m364