Skip to content

🎨 Palette: [UX improvement] - Accessible Modal Triggers (Spacebar Support)#125

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette/a11y-modal-trigger-links-13690390877261174214
Open

🎨 Palette: [UX improvement] - Accessible Modal Triggers (Spacebar Support)#125
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette/a11y-modal-trigger-links-13690390877261174214

Conversation

@0m364

@0m364 0m364 commented Jun 25, 2026

Copy link
Copy Markdown
Owner

💡 What:
Added role="button" and aria-haspopup="dialog" to the #sitrep-btn anchor tags across concepts.html, contact.html, and products.html. Also updated modal.js to listen for the Spacebar key on these elements, preventing the default scroll behavior and opening the modal.

🎯 Why:
When using <a> tags with href="#" to open modals, they lack the correct semantic button meaning for screen readers. Furthermore, while native anchors trigger on Enter, screen readers and keyboard users expect buttons to respond to both Enter and Spacebar. Without this fix, pressing Spacebar on the OSINT links simply scrolls the page down, which is a frustrating experience.

📸 Before/After:
(Visuals remain unchanged, but interaction is improved)

  • Before: Screen readers announce "OSINT, link". Pressing Spacebar scrolls the page down.
  • After: Screen readers announce "OSINT, button, opens dialog". Pressing Spacebar correctly opens the modal without scrolling.

Accessibility:

  • Added role="button" and aria-haspopup="dialog".
  • Added JavaScript keydown listener to handle Spacebar navigation for non-native button elements.
  • Logged critical learning in .Jules/palette.md.

PR created automatically by Jules for task 13690390877261174214 started by @0m364

Update OSINT/Sitrep modal trigger anchor tags across concepts.html, contact.html, and products.html to use `role="button"` and `aria-haspopup="dialog"`.
Add `keydown` event listener in `modal.js` to support triggering the modal via the `Spacebar` key for keyboard users and screen readers, preventing default page scrolling.
Documented learning in `.Jules/palette.md`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant