🎨 Palette: [UX improvement] - Accessible Modal Triggers (Spacebar Support)#125
Conversation
Update OSINT/Sitrep modal trigger anchor tags across concepts.html, contact.html, and products.html to use `role="button"` and `aria-haspopup="dialog"`. Add `keydown` event listener in `modal.js` to support triggering the modal via the `Spacebar` key for keyboard users and screen readers, preventing default page scrolling. Documented learning in `.Jules/palette.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added
role="button"andaria-haspopup="dialog"to the#sitrep-btnanchor tags acrossconcepts.html,contact.html, andproducts.html. Also updatedmodal.jsto listen for theSpacebarkey on these elements, preventing the default scroll behavior and opening the modal.🎯 Why:
When using
<a>tags withhref="#"to open modals, they lack the correct semantic button meaning for screen readers. Furthermore, while native anchors trigger onEnter, screen readers and keyboard users expect buttons to respond to bothEnterandSpacebar. Without this fix, pressingSpacebaron the OSINT links simply scrolls the page down, which is a frustrating experience.📸 Before/After:
(Visuals remain unchanged, but interaction is improved)
Spacebarscrolls the page down.Spacebarcorrectly opens the modal without scrolling.♿ Accessibility:
role="button"andaria-haspopup="dialog".keydownlistener to handleSpacebarnavigation for non-native button elements..Jules/palette.md.PR created automatically by Jules for task 13690390877261174214 started by @0m364