🎨 Palette: Improve accessibility for OSINT modal buttons#123
Conversation
Added `role="button"` and `aria-haspopup="dialog"` to all `<a href="#" id="sitrep-btn">` links across `concepts.html`, `contact.html`, and `products.html` to communicate their purpose to screen readers. Also added a JavaScript `keydown` listener in `modal.js` to trigger the modal via the `Spacebar` key (and prevent default page scrolling), establishing parity with native `<button>` element behavior for keyboard users. Recorded the learning in `.Jules/palette.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
role="button",aria-haspopup="dialog", andSpacebarkey support to the "OSINT" anchor links used to trigger the modal.🎯 Why: Native anchor tags (
<a>) used as buttons do not trigger onSpacebarand are announced incorrectly by screen readers. This update improves semantics and keyboard navigation.📸 Before/After: Visuals remain unchanged, but structural semantics are updated.
♿ Accessibility: Ensures modal triggers are correctly identified as buttons and support full keyboard functionality.
PR created automatically by Jules for task 6453288486695633620 started by @0m364