Skip to content

🎨 Palette: Improve OSINT modal trigger accessibility#121

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-sitrep-btn-accessibility-9647650749021884587
Open

🎨 Palette: Improve OSINT modal trigger accessibility#121
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-sitrep-btn-accessibility-9647650749021884587

Conversation

@0m364

@0m364 0m364 commented Jun 21, 2026

Copy link
Copy Markdown
Owner

💡 What: Added role="button" and aria-haspopup="dialog" to all instances of the #sitrep-btn link. Implemented a keydown listener in modal.js to trigger the modal when the Spacebar is pressed while the button is focused.
🎯 Why: Using an anchor tag (<a>) as a button creates an accessibility gap. Screen reader users need to be informed that the element behaves like a button (and opens a dialog), and keyboard users expect it to respond to the Spacebar key (which <a> tags do not do natively).
📸 Before/After: N/A (Non-visual change).
Accessibility: Fixed a critical interaction bug for keyboard users and improved semantic announcements for screen readers.


PR created automatically by Jules for task 9647650749021884587 started by @0m364

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant