🎨 Palette: Improve OSINT modal trigger accessibility#121
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
role="button"andaria-haspopup="dialog"to all instances of the#sitrep-btnlink. Implemented akeydownlistener inmodal.jsto trigger the modal when theSpacebaris pressed while the button is focused.🎯 Why: Using an anchor tag (
<a>) as a button creates an accessibility gap. Screen reader users need to be informed that the element behaves like a button (and opens a dialog), and keyboard users expect it to respond to the Spacebar key (which<a>tags do not do natively).📸 Before/After: N/A (Non-visual change).
♿ Accessibility: Fixed a critical interaction bug for keyboard users and improved semantic announcements for screen readers.
PR created automatically by Jules for task 9647650749021884587 started by @0m364