🎨 Palette: Add ARIA roles and Spacebar support to anchor-based buttons#118
Conversation
💡 What: Added `role="button"` and `aria-haspopup="dialog"` to the `#sitrep-btn` anchor tags in `concepts.html`, `contact.html`, and `products.html`. Also added a `keydown` listener in `modal.js` to ensure the Spacebar triggers the modal correctly when these anchors are focused. 🎯 Why: To ensure native keyboard and screen reader accessibility for anchor tags repurposed as buttons. Native anchors only trigger on the 'Enter' key, missing the 'Spacebar' expectation for buttons, and they do not announce their role correctly without ARIA attributes. ♿ Accessibility: Ensures full WCAG keyboard navigation support (Enter and Space) and proper screen reader semantic announcements for the OSINT/Sitrep modal buttons.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎨 Palette: Add ARIA roles and Spacebar support to anchor-based buttons
💡 What: Added
role="button"andaria-haspopup="dialog"to the#sitrep-btnanchor tags inconcepts.html,contact.html, andproducts.html. Also added akeydownlistener inmodal.jsto ensure the Spacebar triggers the modal correctly when these anchors are focused.🎯 Why: To ensure native keyboard and screen reader accessibility for anchor tags repurposed as buttons. Native anchors only trigger on the 'Enter' key, missing the 'Spacebar' expectation for buttons, and they do not announce their role correctly without ARIA attributes.
♿ Accessibility: Ensures full WCAG keyboard navigation support (Enter and Space) and proper screen reader semantic announcements for the OSINT/Sitrep modal buttons.
PR created automatically by Jules for task 8018514010772663801 started by @0m364