Skip to content

🎨 Palette: Add Spacebar and ARIA support to OSINT Modal Buttons#117

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-sitrep-btn-a11y-3103760334757681454
Open

🎨 Palette: Add Spacebar and ARIA support to OSINT Modal Buttons#117
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-sitrep-btn-a11y-3103760334757681454

Conversation

@0m364

@0m364 0m364 commented Jun 17, 2026

Copy link
Copy Markdown
Owner

💡 What: Added role="button" and aria-haspopup="dialog" to all instances of the "OSINT" (#sitrep-btn) links across concepts.html, products.html, and contact.html. Also updated modal.js to listen for the Spacebar keydown event and trigger the modal properly.

🎯 Why: The OSINT links look like buttons and function as triggers for a modal dialog, but they were using <a> tags. Screen readers announce them as navigation links rather than dialog-triggering buttons, and keyboard users expect buttons to activate with both Enter and Space.

📸 Before/After: No visual changes. Keyboard interaction is improved for spacebar pressing.

Accessibility: Fixes incorrect semantics and improves keyboard support for the sitrep trigger.


PR created automatically by Jules for task 3103760334757681454 started by @0m364

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant