🎨 Palette: Anchor Tag Button Accessibility#115
Conversation
- Added role="button" and aria-haspopup="dialog" to OSINT modal links. - Implemented spacebar activation for the #sitrep-btn anchors to support standard keyboard behavior. - Documented learning in .Jules/palette.md.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
role="button"andaria-haspopup="dialog"to all<a href="#" id="sitrep-btn">links, and implemented akeydownlistener for theSpacebarkey (withe.preventDefault()) to trigger the modal.🎯 Why: While native
<button>tags are preferable, when<a href="#">tags must be used to trigger actions like modals, they lack native semantics and keyboard support. Screen readers won't announce them as buttons, and keyboard users expect Spacebar to activate buttons (which fails on anchors, causing page scroll instead). This ensures the link behaves identically to a native button.📸 Before/After: The visual experience is identical. The "OSINT" button still triggers the modal.
♿ Accessibility: Screen readers now announce the "OSINT" link as a button that opens a dialog. Keyboard users can now trigger the modal using the Spacebar (in addition to the Enter key) without the page scrolling abruptly.
PR created automatically by Jules for task 2999312093088357235 started by @0m364