Skip to content

🎨 Palette: Improve keyboard accessibility for modal triggers #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0m364 wants to merge 1 commit into
base: add-0m364-website-1232764033486168073
Choose a base branch
from
Open

🎨 Palette: Improve keyboard accessibility for modal triggers #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@
## 2026-06-12 - Robust Skip-to-Content Links
**Learning:** Adding a "Skip to main content" link is a critical accessibility requirement for keyboard users. To make it robust, it needs to be hidden visually but appear when focused using `transform: translateY(-100%)` instead of magic pixel numbers, and the target container (e.g., `<main>`) must have a matching `id` and `tabindex="-1"` so it can programmatically receive focus across all browsers.
**Action:** Always include a visually hidden 'Skip to main content' link immediately after the opening `<body>` tag. Set the main content container with an `id` and explicitly `tabindex="-1"`.

## 2026-06-13 - Anchor tags as Modal Triggers
**Learning:** Using `<a>` tags with `href="#"` as buttons to trigger modals is a common pattern, but it breaks accessibility expectations. Screen readers announce them as links, confusing users who expect a navigation action, and native links only respond to the `Enter` key, whereas standard `<button>`s also respond to the `Space` key.
**Action:** Whenever using `<a>` tags as action triggers, enforce accessibility by adding `role="button"` and `aria-haspopup="dialog"` to the HTML. Furthermore, bind a `keydown` event listener in JavaScript for the `Space` key (or `Spacebar`), calling `e.preventDefault()` to stop page scrolling before executing the modal open function.
2 changes: 1 addition & 1 deletion concepts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h1>CHARLES WILLIAMS</h1>
<a href="products.html">Products</a>
<a href="concepts.html" class="active" aria-current="page">Concepts</a>
<a href="contact.html">Contact</a>
<a href="#" id="sitrep-btn">OSINT</a>
<a href="#" id="sitrep-btn" role="button" aria-haspopup="dialog">OSINT</a>
</nav>
<div id="local-info" class="local-info-widget"></div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion contact.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ <h2>Get in Touch</h2>
</a>


<a href="#" id="sitrep-btn" class="button">
<a href="#" id="sitrep-btn" class="button" role="button" aria-haspopup="dialog">
<svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-activity"><polyline points="22 12 18 12 15 21 9 3 6 12 2 12"></polyline></svg>
OSINT
</a>
Expand Down
6 changes: 6 additions & 0 deletions modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ const openModal = (e) => {
const btns = document.querySelectorAll('#sitrep-btn');
btns.forEach(btn => {
btn.addEventListener('click', openModal);
btn.addEventListener('keydown', (e) => {
if (e.key === ' ' || e.key === 'Spacebar') {
e.preventDefault();
openModal(e);
}
});
});

// Close modal via button
Expand Down
2 changes: 1 addition & 1 deletion products.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1>CHARLES WILLIAMS</h1>
<a href="products.html" class="active" aria-current="page">Products</a>
<a href="concepts.html">Concepts</a>
<a href="contact.html">Contact</a>
<a href="#" id="sitrep-btn">OSINT</a>
<a href="#" id="sitrep-btn" role="button" aria-haspopup="dialog">OSINT</a>
</nav>
<div id="local-info" class="local-info-widget"></div>
</div>
Expand Down