Skip to content

Update gosdk#668

Merged
dabasov merged 3 commits intostagingfrom
fix/gosdk-1.19.8
Feb 25, 2025
Merged

Update gosdk#668
dabasov merged 3 commits intostagingfrom
fix/gosdk-1.19.8

Conversation

@Hitenjain14
Copy link
Contributor

@Hitenjain14 Hitenjain14 commented Feb 25, 2025

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@Hitenjain14 Hitenjain14 marked this pull request as draft February 25, 2025 11:48
dabasov
dabasov approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jayashsatolia403 Jayashsatolia403 marked this pull request as ready for review February 25, 2025 15:09
@dabasov dabasov merged commit bf90249 into staging Feb 25, 2025
5 of 6 checks passed
@dabasov dabasov deleted the fix/gosdk-1.19.8 branch February 25, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dabasov dabasov dabasov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hitenjain14 @dabasov

Comments