Skip to content

Add missing js-yaml runtime dependency#18

Open
MrDiscipline wants to merge 1 commit into
ziquid:devfrom
MrDiscipline:fix-js-yaml-runtime-dependency
Open

Add missing js-yaml runtime dependency#18
MrDiscipline wants to merge 1 commit into
ziquid:devfrom
MrDiscipline:fix-js-yaml-runtime-dependency

Conversation

@MrDiscipline

Copy link
Copy Markdown

Summary

  • add js-yaml as a runtime dependency because settings-manager.ts imports it at startup
  • add @types/js-yaml for the TypeScript import
  • update the lockfile minimally so the dependency is no longer dev-only

Fixes #17.

Verification

npm run typecheck
npm run build

I also packed this branch and installed it into a clean temporary npm project:

npm pack
npm init -y
npm install /path/to/zds-ai-cli-0.2.0-alpha.5.tgz
./node_modules/.bin/zai-cli --help
./node_modules/.bin/zai-cli --version

The packed build prints help successfully and --version prints 0.2.0-alpha.5.

For comparison, the currently published @zds-ai/cli@0.1.10 fails in a clean project with:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'js-yaml' imported from .../node_modules/@zds-ai/cli/dist/utils/settings-manager.js

Note

npm test -- --runInBand still has an existing unrelated failure in tests/tool-call-ordering.test.ts where stripFn is not a function. This PR does not touch that code path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zai-cli --help fails after clean npm install because js-yaml is missing

1 participant