Add missing js-yaml runtime dependency#18
Open
MrDiscipline wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js-yamlas a runtime dependency becausesettings-manager.tsimports it at startup@types/js-yamlfor the TypeScript importFixes #17.
Verification
I also packed this branch and installed it into a clean temporary npm project:
The packed build prints help successfully and
--versionprints0.2.0-alpha.5.For comparison, the currently published
@zds-ai/cli@0.1.10fails in a clean project with:Note
npm test -- --runInBandstill has an existing unrelated failure intests/tool-call-ordering.test.tswherestripFnis not a function. This PR does not touch that code path.