Fix:

- ai: safer handling of malformed API responses prevents potential crashes
- app: case-insensitive .app bundle detection catches more installed apps on macOS
- app: reduced unnecessary cloning and memory allocations across all modules
- app: removed redundant unsafe Send/Sync impls on progress tracker
- ci: Linux builds now install required X11 system dependencies
- ci: clippy checks split into lib and test targets for better lint coverage

Author: aejimmi

.github/workflows/ci.yml

@@ -39,6 +39,8 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v4
+      - name: Install system dependencies
+        run: sudo apt-get update && sudo apt-get install -y libxcb1-dev libxkbcommon-dev libxkbcommon-x11-dev
       - uses: dtolnay/rust-toolchain@stable
         with:
           components: clippy
@@ -47,18 +49,32 @@ jobs:
         with:
           prefix-key: "v1-rust"
           cache-on-failure: true
-      - name: Clippy
+      - name: Clippy (lib)
         env:
           SCCACHE_GHA_ENABLED: "true"
           RUSTC_WRAPPER: "sccache"
-        run: cargo clippy --workspace --all-targets --locked -- -D warnings
+        run: cargo clippy --workspace --lib --locked -- -D warnings
+      - name: Clippy (tests)
+        env:
+          SCCACHE_GHA_ENABLED: "true"
+          RUSTC_WRAPPER: "sccache"
+        run: >-
+          cargo clippy --workspace --tests --bins --locked -- -D warnings
+          -A clippy::unwrap_used -A clippy::indexing_slicing
+          -A clippy::needless_raw_string_hashes -A clippy::unreadable_literal
+          -A clippy::uninlined_format_args -A clippy::single_char_pattern
+          -A clippy::float_cmp -A clippy::redundant_closure
+          -A clippy::default_trait_access -A clippy::ignore_without_reason
+          -A clippy::manual_let_else -A clippy::panic
 
   test:
     name: Test
     runs-on: ubuntu-latest
     timeout-minutes: 30
     steps:
       - uses: actions/checkout@v4
+      - name: Install system dependencies
+        run: sudo apt-get update && sudo apt-get install -y libxcb1-dev libxkbcommon-dev libxkbcommon-x11-dev
       - uses: dtolnay/rust-toolchain@stable
       - name: Setup mold linker
         uses: rui314/setup-mold@v1

CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## v0.7.1
+
+Fix:
+- ai: safer handling of malformed API responses prevents potential crashes
+- app: case-insensitive .app bundle detection catches more installed apps on macOS
+- app: reduced unnecessary cloning and memory allocations across all modules
+- app: removed redundant unsafe Send/Sync impls on progress tracker
+- ci: Linux builds now install required X11 system dependencies
+- ci: clippy checks split into lib and test targets for better lint coverage
+
 ## v0.8.0
 
 - app: reorganized into 28 independent crates for faster builds and modular composition

Cargo.lock

@@ -33,7 +33,7 @@ exclude = ["vendor"]
 resolver = "2"
 
 [workspace.package]
-version = "0.7.0"
+version = "0.7.1"
 edition = "2024"
 rust-version = "1.94.0"
 license = "MIT"

Cargo.toml

@@ -48,7 +48,7 @@ pub struct Executor {
 
 impl Executor {
     /// Create a new executor
-    pub async fn new(config: ExecutorConfig) -> Result<Self, ExecutorError> {
+    pub fn new(config: ExecutorConfig) -> Result<Self, ExecutorError> {
         let db = CacheDb::open().map_err(ExecutorError::Database)?;
 
         Ok(Self {
@@ -233,9 +233,7 @@ impl Executor {
             }
 
             // Check destination is available
-            let dest_mount = if let Some(m) = self.get_destination_mount(&automation).await {
-                m
-            } else {
+            let Some(dest_mount) = self.get_destination_mount(&automation).await else {
                 tracing::debug!(automation_id = automation.id, "Destination not available");
                 continue;
             };
@@ -338,7 +336,7 @@ impl Executor {
     }
 
     /// Mark interrupted runs on startup
-    pub async fn recover_interrupted_runs(&self) -> Result<u64, ExecutorError> {
+    pub fn recover_interrupted_runs(&self) -> Result<u64, ExecutorError> {
         let count = self.db.mark_interrupted_on_startup()?;
 
         if count > 0 {
@@ -349,7 +347,7 @@ impl Executor {
     }
 
     /// Get resumable runs
-    pub async fn get_resumable_runs(&self) -> Result<Vec<Run>, ExecutorError> {
+    pub fn get_resumable_runs(&self) -> Result<Vec<Run>, ExecutorError> {
         self.db
             .find_resumable_runs()
             .map_err(ExecutorError::Database)

crates/automation/src/executor.rs

@@ -147,7 +147,7 @@ async fn test_recover_interrupted_runs() {
     assert_eq!(run.status, RunStatus::Running);
 
     // Recover interrupted runs
-    let count = executor.recover_interrupted_runs().await.unwrap();
+    let count = executor.recover_interrupted_runs().unwrap();
     assert_eq!(count, 1);
 
     // Check run is now partial
@@ -178,7 +178,7 @@ async fn test_manual_trigger() {
             triggers: Triggers::default(),
             paths: vec![PathMapping {
                 source: source_dir.to_string_lossy().to_string(),
-                dest: "".to_string(),
+                dest: String::new(),
                 exclude: vec![],
             }],
             settings: Settings {