Serialization requirement in the test arguments

[friendly-source-bot]

^{Issue created by @rubenhak as Bitbucket Issue #​19 on 2016.10.15 13:59.}
The NUnit.ApplicationDomain requires test arguments to be Serializable. It indeed might be a valid requirement, but when an argument is not serializable the test infra hangs in "Cancelling" state waiting for the text execution to be terminated.

The test returned following error:
System.Runtime.Serialization.SerializationException : Type 'MyType' in assembly 'MyAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' is not marked as serializable.

private static MyType[] MyTestData = new[]{
            new MyTestData(1),
            new MyTestData(2),
            new MyTestData(3),
            new MyTestData(4)
            };


[Test]
[RunInApplicationDomain]
public void MyTest([ValueSource("MyTestData")]MyType testData)
{

}

[friendly-source-bot]

^{On 2016.10.15 14:10, @zastrowm commented:}
This is a side-effect of how we run the tests, especially how we pass the arguments into the app domain.

However, we should detect this case better and we should not hang, I'll take a look at what can be done to fail earlier.

[friendly-source-bot]

^{On 2016.10.15 14:10 @zastrowm modified issue:}
status changed new → open

[friendly-source-bot]

^{On 2016.10.15 14:17, @zastrowm commented:}
@rubenhak what runner did you use that hung when you ran the test?

[friendly-source-bot]

^{On 2016.10.15 14:29, @zastrowm commented:}
FYI, types that are [Serializable] or derive from MarshallByRef should work as method arguments

[friendly-source-bot]

^{On 2016.10.15 16:01, @rubenhak commented:}
I was using visual studio runner. The [Serializable] attribute did the trick, but wanted to let you know about the hanging.

BTW, thanks for this project. This turned out to be very very useful!

[friendly-source-bot]

^{On 2016.10.15 16:18, @zastrowm commented:}
You're very welcome!

I'll take a look at the VS runner to see what I can do to fix the hang!

[friendly-source-bot]

^{On 2016.10.17 22:51, @rubenhak commented:}
Thanks.

[friendly-source-bot]

^{On 2020.01.01 11:37 @zastrowm modified issue:}
priority changed major → minor