Nuke Write Creator fails with missing legacy template keys

[sebastianbrandhuber]

Is there an existing issue for this?

• I have searched the existing issues and added correct labels.

Description

Current Behavior

Creating a nuke render(write) publish type (Ayon Nuke 0.3.16 and Ayon Core 1.7.2) fails
because of missing template key "asset".

Expected Behavior

When using "{folder[name]}" in the ayon-nuke bundle settings for the Write Creator path template it should not be replaced with "{asset}" since this was removed in Core 1.7.0.

Steps To Reproduce:

1. Using Ayon Nuke 0.3.16 and Ayon Core 1.7.2
2. Open Nuke, create a Render(write) with "{folder[name]}" in the path template settings.
3. Ayon Creation fails with an unresolved template error; missing keys "asset".

Additional context:

This is most likely happening because of this part in the ayon nuke api:

ayon-nuke/client/ayon_nuke/api/plugin.py

Lines 542 to 548 in f6e431e

	# TODO remove template key replacements
	temp_rendering_path_template = (
	temp_rendering_path_template
	.replace("{product[name]}", "{subset}")
	.replace("{product[type]}", "{family}")
	.replace("{task[name]}", "{task}")
	.replace("{folder[name]}", "{asset}")

in combination with this:
ynput/ayon-core#1609

Any reason why this TODO part still exists?
Can it be safely removed for the next release?

Relevant log output:

Creator: Render (write) (create_write_render)

Error: Creator error: Template "xxx/{project[name]}/{hierarchy}/{asset}/comp/work/{asset}_{subset}_{user}/{asset}_{subset}_{user}.{frame}.{ext}" is unsolved. Missing keys: "asset".

[BigRoy]

@iLLiCiTiT @jakubjezek001 any chance you know? Sounds problematic since we've released core updates that removed those keys if I'm not mistaken.

[iLLiCiTiT]

We really should make nuke fully AYONized, it is still same from OpenPype.