Merge pull request #791 from ydb-platform/fix_message_larger_than_limit

Make "Sent message larger than max" error non retryable

Author: vgvoleg

tests/test_errors.py

@@ -1,7 +1,36 @@
+import unittest.mock
+
+import grpc
 import ydb
 import pytest
 
 from os import path
+from ydb.connection import _rpc_error_handler
+
+
+def _make_rpc_error(code, details):
+    error = unittest.mock.MagicMock(spec=grpc.Call)
+    error.code.return_value = code
+    error.details.return_value = details
+    return error
+
+
+def test_resource_exhausted_large_message_returns_bad_request():
+    rpc_error = _make_rpc_error(
+        grpc.StatusCode.RESOURCE_EXHAUSTED,
+        "CLIENT: Sent message larger than max (101289032 vs. 64000000)",
+    )
+    result = _rpc_error_handler("test_rpc", rpc_error)
+    assert isinstance(result, ydb.issues.BadRequest)
+
+
+def test_resource_exhausted_other_reason_returns_connection_lost():
+    rpc_error = _make_rpc_error(
+        grpc.StatusCode.RESOURCE_EXHAUSTED,
+        "Quota exceeded",
+    )
+    result = _rpc_error_handler("test_rpc", rpc_error)
+    assert isinstance(result, ydb.issues.ConnectionLost)
 
 
 def test_scheme_error(driver_sync, database):

ydb/connection.py

@@ -98,6 +98,9 @@ def _rpc_error_handler(
             return issues.Unimplemented("Method or feature is not implemented on server!")
         elif rpc_error.code() == grpc.StatusCode.CANCELLED:
             return issues.Cancelled(rpc_error.details())
+        elif rpc_error.code() == grpc.StatusCode.RESOURCE_EXHAUSTED:
+            if "Sent message larger than max" in rpc_error.details():
+                return issues.BadRequest(rpc_error.details())
         elif use_unavailable and rpc_error.code() == grpc.StatusCode.UNAVAILABLE:
             return issues.Unavailable(rpc_error.details())