From a3ac8cf6a0be76e7e8acea092b4f5fed1d89a7f4 Mon Sep 17 00:00:00 2001 From: Bingran Hu Date: Tue, 12 Aug 2025 14:43:53 -0400 Subject: [PATCH 1/2] remove ranges optimization check --- exports/lint-configs/.clang-tidy | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exports/lint-configs/.clang-tidy b/exports/lint-configs/.clang-tidy index 1b00f10..f22a8a0 100644 --- a/exports/lint-configs/.clang-tidy +++ b/exports/lint-configs/.clang-tidy @@ -9,6 +9,7 @@ WarningsAsErrors: >- # Disabled checks: # - `bugprone-easily-swappable-parameters` because it's difficult to mitigate. +# - `modernize-use-ranges` because we want to support compilations with llvm/apple clang 15. # - `portability-template-virtual-member-function` because we don't support MSVC compilers yet. # - `readability-identifier-length` because it's case-dependent. # - `readability-named-parameter` because we don't want to enforce that all parameters have a name. @@ -24,6 +25,7 @@ Checks: >- cppcoreguidelines-*, misc-*, modernize-*, + -modernize-use-ranges, performance-*, portability-*, -portability-template-virtual-member-function, From 192b63f9adafefe80e2d45ffef63fa5e0d2bd034 Mon Sep 17 00:00:00 2001 From: Bingran Hu Date: Wed, 13 Aug 2025 11:55:04 +0800 Subject: [PATCH 2/2] Update exports/lint-configs/.clang-tidy Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> --- exports/lint-configs/.clang-tidy | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exports/lint-configs/.clang-tidy b/exports/lint-configs/.clang-tidy index f22a8a0..8ae296d 100644 --- a/exports/lint-configs/.clang-tidy +++ b/exports/lint-configs/.clang-tidy @@ -9,7 +9,8 @@ WarningsAsErrors: >- # Disabled checks: # - `bugprone-easily-swappable-parameters` because it's difficult to mitigate. -# - `modernize-use-ranges` because we want to support compilations with llvm/apple clang 15. +# - `modernize-use-ranges` because we want to support compiling C++20 code with LLVM/Apple Clang 15, +# but those compiler versions don't support ranges. # - `portability-template-virtual-member-function` because we don't support MSVC compilers yet. # - `readability-identifier-length` because it's case-dependent. # - `readability-named-parameter` because we don't want to enforce that all parameters have a name.