From 0f3c6d3960b6240ffe0afcc4389e0501a3913b26 Mon Sep 17 00:00:00 2001
From: y-azy <25907755+y-azy@users.noreply.github.com>
Date: Sun, 12 Jan 2025 23:01:30 -0500
Subject: [PATCH] fix(logging) - corrected indentation and setup in
 global_logger.py

- indentation and formatting

- Added console and optional file logging

- Created test_logger.py to verify logging functionality
---
 Services/ml_model/global_logger.py | 12 ++++++------
 Services/ml_model/test_logger.py   | 15 +++++++++++++++
 2 files changed, 21 insertions(+), 6 deletions(-)
 create mode 100644 Services/ml_model/test_logger.py

diff --git a/Services/ml_model/global_logger.py b/Services/ml_model/global_logger.py
index 7941175..dc29ec3 100644
--- a/Services/ml_model/global_logger.py
+++ b/Services/ml_model/global_logger.py
@@ -9,17 +9,17 @@ def __init__(self, log_file=None):
         ch = logging.StreamHandler()
         ch.setLevel(logging.DEBUG)
         
-        # Create file handler if log_file is provided
+        # Create formatter
+        formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s - %(data)s')
+        ch.setFormatter(formatter)
+        self.logger.addHandler(ch)
+        
+        # Add file handler if specified
         if log_file:
             fh = logging.FileHandler(log_file)
             fh.setLevel(logging.DEBUG)
-            formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s - %(data)s')
             fh.setFormatter(formatter)
             self.logger.addHandler(fh)
-        
-        formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s - %(data)s')
-        ch.setFormatter(formatter)
-        self.logger.addHandler(ch)
 
     def info(self, message, extra=None):
         if extra is None:
diff --git a/Services/ml_model/test_logger.py b/Services/ml_model/test_logger.py
new file mode 100644
index 0000000..cf6ad4d
--- /dev/null
+++ b/Services/ml_model/test_logger.py
@@ -0,0 +1,15 @@
+from global_logger import global_logger
+
+def test_logger():
+    # Test different log levels
+    global_logger.info("Test info message")
+    global_logger.error("Test error message")
+    global_logger.debug("Test debug message")
+    
+    # Test with extra data
+    global_logger.info("Test with data", extra={"data": "test_value"})
+
+    print("Check the log file and console output for messages")
+
+if __name__ == "__main__":
+    test_logger()