IPC for xal extent tree#65
Open
NaddiNadja wants to merge 15 commits into
Open
Conversation
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
There are informations on the homid struct that can be necessary to know from the threaded workers that handle the requests from clients. The homid_ipc_accept() function's argument is changed to be the whole homid struct instead of just the connection struct, such that this can be passed on to the worker arguments. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Contributor
Author
hehe yes, I will close that one
Yes, that would probably be a good idea |
Closed
siu-jung
approved these changes
May 13, 2026
Collaborator
There was a problem hiding this comment.
Is there an advantage to reconnecting to the socket at every request vs. keeping it open?
Contributor
Author
There was a problem hiding this comment.
Not really, but the problem was that it wasn't being kept open, so if I did two different calls, it failed the second one due to the socket having been closed for some reason
karlowich
requested changes
May 13, 2026
Contributor
karlowich
left a comment
karlowich
left a comment
There was a problem hiding this comment.
Very nice!
Just a few nitpicks
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
By using the xal enums, we can simplify the parsing of the given config file. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
This allows clients to know whether or not they can read from the extent tree in the shared memory. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
It was not intuitive, from the knowledge of other projects, that running "make" would also start the service. This has ben removed from the default, and config/build has been split in two commands. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
This allows both client and daemon side code to use this constant Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Not added directly to the white paper, but it's referenced there. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
The HOMI implementation is already eplained, but a couple of sentences about the shared memory and IPC is added here. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Contributor
Author
|
@karlowich I've addressed your comments in the last commit - and also added two commits for docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A larger PR with some minor fixes here and there, and then the full functionality for sharing the xal pools with the client. It depends on some of the functionalities from this PR in xal: xnvme/xal#28