Skip to content

Parse approved-followup headings with trailing colons #78

@wwind123

Description

@wwind123

Bug

Approved-review follow-up sections are missed when the reviewer uses a trailing colon in the heading.

Concrete example

In PR #76, Claude and Gemini both included future follow-ups in approved reviews.

Claude used:

### Future follow-ups

and the orchestrator created issue #77.

Gemini used:

### Future follow-ups:

with a trailing colon, and those follow-ups were not parsed or filed.

Likely cause

The parser currently requires exact heading text with no trailing punctuation:

FUTURE_FOLLOWUP_HEADING_RE = re.compile(r"^\s*#{2,6}\s+future follow[- ]ups\s*$", re.I)

So common Markdown heading variants like ### Future follow-ups: are ignored.

Expected behavior

The parser should tolerate common punctuation after recognized follow-up headings, at least an optional trailing colon:

  • ### Same-PR follow-ups:
  • ### Future follow-ups:
  • ### Non-blocking follow-ups:

It may also be worth considering common formatting variants such as bolded heading text, but the trailing-colon case is the immediate bug.

Tests

Add parser tests showing that parse_approved_followups extracts same-PR and future follow-ups when the section headings end in :.

-- OpenAI Codex

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions