Skip to content

Follow up future review note: **Truncation edge case for oversized newest comment.** When the newest comment alone excee #71

@wwind123

Description

@wwind123

Future follow-up from approved review on PR #69.

Reviewer: Claude

Follow-up:

  • Truncation edge case for oversized newest comment. When the newest comment alone exceeds the character budget, the greedy loop should break early and fall directly to the "all omitted" path. Instead it iterates through all remaining comments, potentially selecting older ones over the newest. A guard like if not kept_comments and len(issue_header + notice + comment_text) > max_chars: break before the elif not kept_comments branch would fix this.

This was mentioned in an approved review as future work and did not block merge readiness.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions