Disable output info on CLI?

[remcotolsma]

We run the WordPress cron via the following cron job command:

wp cron event run --due-now --quiet

Here we deliberately use the --quiet parameter so that the command does not give any output. If there is output due to errors, we will receive an e-mail notification about it. Because BackWPup does give standard output, we now also receive a daily e-mail notification with the BackWPup CLI info:

backwpup/inc/class-job.php

Lines 617 to 620 in 0fc9138

	//output info on cli
	if (php_sapi_name() == 'cli' && defined('STDOUT')) {
	fwrite(STDOUT, strip_tags($info));
	}

Is it possible to add something to disable this CLI info write?

[remcotolsma]

I just discovered that the problem is not only in the following lines of code:

backwpup/inc/class-job.php

Lines 617 to 620 in 0fc9138

	//output info on cli
	if (php_sapi_name() == 'cli' && defined('STDOUT')) {
	fwrite(STDOUT, strip_tags($info));
	}

The following lines of code are also relevant here:

backwpup/inc/class-job.php

Lines 864 to 887 in 92f32e1

	//print message to cli
	if (defined(\WP_CLI::class) && WP_CLI) {
	$output_message = str_replace(['…', ' '], ['...', ' '], esc_html($message));
	if (!call_user_func(['\cli\Shell', 'isPiped'])) {
	if ($error) {
	$output_message = '%r' . $output_message . '%n';
	}
	if ($warning) {
	$output_message = '%y' . $output_message . '%n';
	}
	$output_message = call_user_func(['\cli\Colors', 'colorize'], $output_message, true);
	}
	WP_CLI::line($output_message);
	} elseif (php_sapi_name() == 'cli' && defined('STDOUT')) {
	$output_message = str_replace(
	['…', ' '],
	[
	'...',
	' ',
	],
	esc_html($message)
	) . PHP_EOL;
	fwrite(STDOUT, $output_message);
	}

Checking the availability of WP_CLI is a possible solution.

Should the WP_CLI::log() method be used instead of WP_CLI::line( )?

Message is written to STDOUT, or discarded when --quiet flag is supplied.

https://make.wordpress.org/cli/handbook/references/internal-api/wp-cli-log/

Message is written to STDOUT. WP_CLI::log() is typically recommended; WP_CLI::line() is included for historical compat.

https://make.wordpress.org/cli/handbook/references/internal-api/wp-cli-line/

I personally prefer this approach:

if ( \method_exists( WP_CLI::class, 'log' ) ) {
	WP_CLI::log( $message );
}