Integrate WordPressKit via source code (#24771)

* Fix imports

* Add a bridging header to the share extension targets

Without this, Objective-C APIs that contains Swift types in WordPressKit
will not be available to Swift code in the share extension targets.

* Add a Swift compiler flag to all targets

* Use WordPressComRestApi explicitly

* fix imports

* `RemoteLikeUser` properties are now Optional

* Update WordPressKit

* Remove unused getLikes stub

* Fix a OCMock unit test

* Remove a duplicated import

* Remove a few unnecessary import statements

Author: crazytonyli

Modules/Package.resolved

@@ -50,7 +50,7 @@ let package = Package(
         .package(url: "https://github.com/wordpress-mobile/NSURL-IDN", revision: "b34794c9a3f32312e1593d4a3d120572afa0d010"),
         .package(
             url: "https://github.com/wordpress-mobile/WordPressKit-iOS",
-            revision: "440d94e3a3d6f9f39035a371984e088a2fb42a32"
+            branch: "rework-spm"
         ),
         .package(url: "https://github.com/zendesk/support_sdk_ios", from: "8.0.3"),
         // We can't use wordpress-rs branches nor commits here. Only tags work.
@@ -273,6 +273,7 @@ enum XcodeSupport {
             .product(name: "ZIPFoundation", package: "ZIPFoundation"),
             .product(name: "Aztec", package: "AztecEditor-iOS"),
             .product(name: "WordPressEditor", package: "AztecEditor-iOS"),
+            .product(name: "WordPressKit", package: "WordPressKit-iOS"),
         ]
 
         let testDependencies: [Target.Dependency] = [
@@ -392,6 +393,7 @@ enum XcodeSupport {
                 .product(name: "CocoaLumberjack", package: "CocoaLumberjack"),
                 .product(name: "CocoaLumberjackSwift", package: "CocoaLumberjack"),
                 .product(name: "WordPressAPI", package: "wordpress-rs"),
+                .product(name: "WordPressKit", package: "WordPressKit-iOS"),
             ]),
             .xcodeTarget("XcodeTarget_Intents", dependencies: [
                 "BuildSettingsKit",

Modules/Package.swift

@@ -266,8 +266,10 @@ actor StatsService: StatsServiceProtocol {
                 excludeUserIDs: nil,
                 success: { users, found in
                     let likeUsers = users.map { remoteLike in
-                        PostLikesData.PostLikeUser(
-                            id: remoteLike.userID.intValue,
+                        wpAssert(remoteLike.userID != nil, "user id must not be nil")
+
+                        return PostLikesData.PostLikeUser(
+                            id: remoteLike.userID?.intValue ?? 0,
                             name: remoteLike.displayName ?? remoteLike.username ?? "",
                             avatarURL: remoteLike.avatarURL.flatMap(URL.init)
                         )

Modules/Sources/JetpackStats/Services/StatsService.swift

@@ -1,5 +1,9 @@
 #import <Foundation/Foundation.h>
 
+// This is a strange hack to make the `-[LoginFacadeDelegate needsMultifactorCodeForUserID:andNonceInfo:]`
+// available in Objective-C runtime.
+@import WordPressKit;
+
 NS_ASSUME_NONNULL_BEGIN
 
 @class LoginFields;

Sources/WordPressAuthenticator/Helpers/LoginFacade.h

@@ -7,6 +7,7 @@
 @import WordPressShared;
 @import NSObject_SafeExpectations;
 @import NSURL_IDN;
+@import WordPressKit;
 
 @class Comment;
 

Sources/WordPressData/Objective-C/Blog.m

@@ -3,6 +3,7 @@
 #import "WordPressData-Swift.h"
 
 @import WordPressKit;
+@import WordPressKitModels;
 @import WordPressShared;
 @import NSObject_SafeExpectations;
 

Sources/WordPressData/Objective-C/PostHelper.m

@@ -4,6 +4,7 @@
 #import "WordPressData-Swift.h"
 
 @import WordPressKit;
+@import WordPressKitModels;
 @import WordPressShared;
 
 // These keys are used in the getStoredComment method

Sources/WordPressData/Objective-C/ReaderPost.m

@@ -2,6 +2,8 @@
 #import <CommonCrypto/CommonDigest.h>
 #import <CoreData/CoreData.h>
 
+@import WordPressKit;
+
 NS_ASSUME_NONNULL_BEGIN
 
 @class AbstractPost;

Sources/WordPressData/Objective-C/include/Blog.h

@@ -1,4 +1,4 @@
-#import <WordPressKit/WordPressKit.h>
+@import WordPressKitObjC;
 
 /**
  @class PostServiceSyncOptions

Sources/WordPressData/Objective-C/include/PostServiceOptions.h

@@ -1,6 +1,8 @@
 #import <Foundation/Foundation.h>
 #import <CoreData/CoreData.h>
 
+@import WordPressKit;
+
 NS_ASSUME_NONNULL_BEGIN
 
 @class Blog;