From 534433a6af90064d3a066298bc96dcf7df0ebbfd Mon Sep 17 00:00:00 2001 From: Walther Date: Fri, 3 Apr 2026 00:13:16 +0300 Subject: [PATCH] docs: fix certbot environment variable instructions variable interpolation for the compose file itself requires the values to be defined outside the file, for example in a `.env` file, or exported in the shell https://docs.docker.com/compose/how-tos/environment-variables/variable-interpolation/ --- ssl/.env | 2 ++ ssl/README.md | 12 ++++++++---- ssl/docker-compose.yml | 3 --- 3 files changed, 10 insertions(+), 7 deletions(-) create mode 100644 ssl/.env diff --git a/ssl/.env b/ssl/.env new file mode 100644 index 000000000..0c89627bb --- /dev/null +++ b/ssl/.env @@ -0,0 +1,2 @@ +CERTBOT_MAIL=certbot@domain.tld +DOMAIN=satisfactory.domain.tld diff --git a/ssl/README.md b/ssl/README.md index 73f4eeae0..c8fd7bab7 100644 --- a/ssl/README.md +++ b/ssl/README.md @@ -4,6 +4,7 @@ The instructions below will help you to deploy a signed SSL certificate for your ## Docker Compose +`docker-compose.yml` ```yaml services: satisfactory-server: @@ -41,13 +42,16 @@ services: - '80:80/tcp' volumes: - ./certs:/etc/letsencrypt - environment: - - CERTBOT_MAIL=certbot@domain.tld - - DOMAIN=satisfactory.domain.tld +``` + +`.env` +``` +CERTBOT_MAIL=certbot@domain.tld +DOMAIN=satisfactory.domain.tld ``` The `docker-compose.yml` file above should replace the `docker-compose.yml` file you already have configured. Adjust the -`CERTBOT_MAIL` and `DOMAIN` environment variables under the `certbot` service to be a real email address, and the domain +`CERTBOT_MAIL` and `DOMAIN` environment variables in the `.env` file to be a real email address, and the domain you'd like to issue the SSL certificate for. Ensure prior to running this that you've already created the necessary DNS record for your domain. If you don't certbot will fail, and you'll likely hit your rate limit and need to wait a while to try again (check the `certbot` container's logs for further information). diff --git a/ssl/docker-compose.yml b/ssl/docker-compose.yml index 857ec377c..d29a4b07a 100644 --- a/ssl/docker-compose.yml +++ b/ssl/docker-compose.yml @@ -34,6 +34,3 @@ services: - '80:80/tcp' volumes: - ./certs:/etc/letsencrypt - environment: - - CERTBOT_MAIL=certbot@domain.tld - - DOMAIN=satisfactory.domain.tld \ No newline at end of file