Skip to content

Pass options to ffmpeg securely #20

Description

@itsrachelfish

Currently ffmpeg is being called by node as a string, command and arguments combined. This lead to a severe bug which locked up the server and clients when files were added to the playlist with "&" in the filename.

Options passed to commands run by node should be sanitized, like the way they are in fishy's rainbow module - https://github.com/itsrachelfish/fishy-bot/blob/master/modules/rainbow.js#L73-L84

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions