ssl not working

[m1stegmann]

Hi,

great code - helped me one of our customers!

ssl is not working because of the use of the kestrel server. A service fabric app has no access to the private keys of a ssl certificate. I think you have to use the WebListener because service fabric gives the WebListener (http.sys) access to this keys.
I have some small modifications and would like to publish my branch to your git repository.

greetings
Michael

[weidazhao]

Hi Michael,

You're right that this is a limitation. I will propagate this back to the team to see if we can have better support for HTTPS on Kestrel + Service Fabric.

Besides using WebListener, I'd like to check if the following alternative is an acceptable solution to you:

Put the certificate in Azure KeyVault (or whatever secure store you'd like to use). When the service is up, use KeyVault API to retrieve the certificate and set it to Kestrel like this:
https://github.com/aspnet/KestrelHttpServer/blob/dev/samples/SampleApp/Startup.cs#L48

Thanks,
-David

[m1stegmann]

Hi David,

I hope there is also WebListerner + SSL Support in the final bits. Currently this doesn’t work without some small modifications Microsoft.ServiceFabric.AspNetCore.Hosting and Microsoft.ServiceFabric.AspNetCore.Gateway!

This are my modifications for the other Team. I think they have to bind on http[s]://+:[port]

WebHostBuilderExtensions.cs:
string serverUrl = $"{endpoint.Protocol.ToLower()}://+:{endpoint.Port}";

AspNetCoreCommunicationListener.cs
return Task.FromResult(string.Join(";", serverAddressesFeature.Addresses.Select(address => $"{address}{_servicePathBase}".Replace("+", host)).Distinct()));
and
return Task.FromResult(string.Join(";", serverAddressesFeature.Addresses.Select(address => address.Replace("+", host)).Distinct()));

I know Kestrel and I would use it with Service Fabric if there is support for this in the ApllicationManifest.xml and the ServiceManifest.xml

Can you share a timeline for the Microsoft.ServiceFabric.AspNetCore.Hosting package from the other team?

Of topic: I using windows and I currently do not need cross platform. Is kestrel or WebListerner faster on windows?

Greetings
Michael

[weidazhao]

Hi Michael,

I've fixed the issue with Microsoft.ServiceFabric.AspNetCore.Hosting to support WebListener (b5ef862).

What is the issue with Gateway?

I currently don't have a timeline for shipping the components as NuGet packages. I will share it as soon as I know it.

Kestrel is the default web server of ASP.NET Core now and it is faster than WebListener on Windows as well. The blog http://web.ageofascent.com/asp-net-core-exeeds-1-15-million-requests-12-6-gbps/ mentioned the result measured upon Kestrel 4 months ago, and the number still keeps increasing.

-David

[m1stegmann]

Hi Davis,

Thank you for the changes and the information’s about the Performance of Kestrel.

With the original code I simple got an status code 500 from the WebListerner when using HTTPS.

Hopefully we can use Kestrel with encryption first class in Service Fabric soon ☺

Greetings
Michael

Von: Weida Zhao [mailto:notifications@github.com]
Gesendet: Monday, June 13, 2016 9:04 PM
An: weidazhao/Hosting Hosting@noreply.github.com
Cc: Michael Stegmann stegmann@noxum.com; Author author@noreply.github.com
Betreff: Re: [weidazhao/Hosting] ssl not working (#29)

Hi Michael,

I've fixed the issue with Microsoft.ServiceFabric.AspNetCore.Hosting to support WebListener (b5ef862b5ef862).

What is the issue with Gateway?

I currently don't have a timeline for shipping the components as NuGet packages. I will share it as soon as I know it.

Kestrel is the default web server of ASP.NET Core now and it is faster than WebListener on Windows as well. The blog http://web.ageofascent.com/asp-net-core-exeeds-1-15-million-requests-12-6-gbps/ mentioned the result measured upon Kestrel 4 months ago, and the number still keeps increasing.

-David

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/29#issuecomment-225676800, or mute the threadhttps://github.com/notifications/unsubscribe/AHxzUVmBO9Jlks0vMYDOyk7HB8uJQZaXks5qLamegaJpZM4Iy2Xp.