Skip to content

Commit 7734fe3

Browse files
authored
Merge pull request #160 from weaviate/jose/fix-defaults
Fix replication_deletion_strategy overriding server default
2 parents 539606a + 2a0f520 commit 7734fe3

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

weaviate_cli/commands/create.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def create() -> None:
156156
type=click.Choice(
157157
["delete_on_conflict", "no_automated_resolution", "time_based_resolution"]
158158
),
159-
help=f"Replication deletion strategy (default: '{CreateCollectionDefaults.replication_deletion_strategy}').",
159+
help="Replication deletion strategy. If not specified, uses the Weaviate server default (time_based_resolution).",
160160
)
161161
@click.option(
162162
"--json", "json_output", is_flag=True, default=False, help="Output in JSON format."
@@ -200,7 +200,7 @@ def create_collection_cli(
200200
shards: int,
201201
vectorizer: Optional[str],
202202
vectorizer_base_url: Optional[str],
203-
replication_deletion_strategy: str,
203+
replication_deletion_strategy: Optional[str],
204204
named_vector: bool,
205205
named_vector_name: Optional[str],
206206
json_output: bool,

weaviate_cli/defaults.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class CreateCollectionDefaults:
7575
shards: int = 0
7676
vectorizer: str = "none"
7777
vectorizer_base_url: Optional[str] = None
78-
replication_deletion_strategy: str = "no_automated_resolution"
78+
replication_deletion_strategy: Optional[str] = None
7979
named_vector: bool = False
8080
named_vector_name: Optional[str] = "default"
8181
object_ttl_type: str = "create"

0 commit comments

Comments
 (0)