orekit/findbugs-exclude-filter.xml at accel · wardev/orekit · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
<?xml version="1.0"?>
<!--
  This file contains some false positive bugs detected by findbugs. Their
  false positive nature has been analyzed individually and they have been
  put here to instruct findbugs it must ignore them.
-->
<FindBugsFilter>

  <!-- the following serialization classes already takes care of non-serializable parts. -->
  <Match>
    <Or>
      <Class name="~.*\.DSSTPropagator\$MeanPlusShortPeriodicMapper\$DataTransferObject$" />
      <Class name="~.*\.IntegratedEphemeris\$DataTransferObject$" />
    </Or>
    <Bug pattern="SE_BAD_FIELD" />
  </Match>

  <!-- the following classes are serialized using writeReplace/readResolve with proxy classes,
       so the is no real problem about the base class not having a proper constructor.
       This is tested in the IntegratedEphemerisTest for the ephemeris and both propagators. -->
  <Match>
    <Or>
      <Class name="~.*\.IntegratedEphemeris$" />
      <Class name="~.*\.DSSTPropagator\$MeanPlusShortPeriodicMapper$" />
      <Class name="~.*\.NumericalPropagator\$OsculatingMapper$" />
    </Or>
    <Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR" />
  </Match>
  <Match>
    <Class name="~.*\.DSSTPropagator\$MeanPlusShortPeriodicMapper$" />
    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
  </Match>
  <Match>
    <Class name="~.*\.GeographicZoneDetector$" />
    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
  </Match>

  <!-- The following is an intentional behaviour, to be removed when class is suppressed -->
  <Match>
    <Class name="~.*\.SpacecraftFrame\$LocalProvider$"/>
    <Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION" />
  </Match>

  <!-- the following are in fact false positives from findbugs -->
  <!-- their occurrence depends on the java compiler used      -->
  <Match>
    <Class name="~.*\.EcksteinHechlerPropagator$"/>
    <Method name="computeMeanParameters" />
    <Or>
      <Local name="epsilon" />
      <Local name="thresholdAngles" />
    </Or>
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  </Match>
  <Match>
    <Class name="~.*\.DTM2000$"/>
    <Method name="computation" />
    <Or>
      <Local name="zlb" />
      <Local name="zlbre" />
    </Or>
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  </Match>
  <Match>
    <Class name="~.*\.SDP4$"/>
    <Method name="thetaG" />
    <Or>
      <Local name="omega_E" />
      <Local name="seconds_per_day" />
      <Local name="jd_2000" />
    </Or>
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  </Match>
  <Match>
    <Class name="~.*\.TLEPropagator$"/>
    <Method name="computePVCoordinates" />
    <Or>
      <Local name="newtonRaphsonEpsilon" />
      <Local name="cv" />
    </Or>
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  </Match>
  <Match>
    <Class name="~.*\.JPLEphemeridesLoader$"/>
    <Method name="tooFarRange" />
    <Local name="fiftyDays" />
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  </Match>
  <Match>
    <Class name="~.*\.JB2006$"/>
    <Method name="getDensity" />
    <Local name="FACT1" />
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  </Match>
  <Match>
    <Class name="~.*\.JB2006$"/>
    <Method name="dTc" />
    <Local name="HP" />
    <Bug pattern="DLS_DEAD_LOCAL_STORE" />
  </Match>

  <!-- the approximate constants do belong to the model -->
  <Match>
    <Class name="~.*\.JB2006$"/>
    <Bug pattern="CNT_ROUGH_CONSTANT_VALUE" />
  </Match>

  <!-- The following is a false positive from findbugs -->
  <Match>
    <Class name="~.*\.IntegratedEphemeris\$LocalProvider$"/>
    <Method name="getAdditionalState" />
    <Bug pattern="BC_VACUOUS_INSTANCEOF" />
  </Match>

  <!-- The following equality tests are intentional and needed for semantic purposes -->
  <Match>
    <Class name="org.orekit.time.TimeComponents" />
    <Method name="equals" params="java.lang.Object" returns="boolean" />
    <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
  </Match>
  <Match>
    <Class name="org.orekit.orbits.KeplerianOrbit"/>
    <Method name ="eMeSinE" params="double" returns="double" />
    <Bug pattern="FE_FLOATING_POINT_EQUALITY" />
  </Match>

  <!-- The following internal representation exposure are intentional,
       They are used to pass data back and forth between classes
    -->
  <Match>
    <Class name="org.orekit.propagation.integration.AdditionalStateData"/>
    <Method name ="getAdditionalState" params="" returns="double[]" />
    <Bug pattern="EI_EXPOSE_REP" />
  </Match>
  <Match>
    <Class name="org.orekit.propagation.integration.AdditionalStateData"/>
    <Method name ="getAdditionalStateDot" params="" returns="double[]" />
    <Bug pattern="EI_EXPOSE_REP" />
  </Match>
  <Match>
    <Class name="org.orekit.forces.gravity.HolmesFeatherstoneAttractionModel$GradientHessian"/>
    <Or>
      <Method name="getGradient" params="" returns="double[]" />
      <Method name="getHessian" params="" returns="double[][]" />
      </Or>
    <Bug pattern="EI_EXPOSE_REP" />
  </Match>
  <Match>
    <Class name="org.orekit.forces.gravity.HolmesFeatherstoneAttractionModel$GradientHessian"/>
    <Method name="&lt;init>"  params="double[],double[][]" returns="void" />
    <Bug pattern="EI_EXPOSE_REP2" />
  </Match>

  <!-- the following is an intended switch fall-through in the SP3Parser -->
  <Match>
    <Class name="~.*\.SP3Parser$"/>
    <Method name="parseHeaderLine" />
    <Bug pattern="SF_SWITCH_FALLTHROUGH" />
  </Match>

</FindBugsFilter>