-
Notifications
You must be signed in to change notification settings - Fork 81
Persist runtime.setUninstallURL() until update #981
Copy link
Copy link
Open
Labels
follow-up: chromeNeeds a response from a Chrome representativeNeeds a response from a Chrome representativeinconsistencyInconsistent behavior across browsersInconsistent behavior across browsersneeds-triage: chromeChrome needs to assess this issue for the first timeChrome needs to assess this issue for the first timeneeds-triage: firefoxFirefox needs to assess this issue for the first timeFirefox needs to assess this issue for the first timeneutral: safariNot opposed or supportive from SafariNot opposed or supportive from Safaritopic: eventsIssues related to the registration, management, and dispatch of WebExtension events.Issues related to the registration, management, and dispatch of WebExtension events.
Metadata
Metadata
Assignees
Labels
follow-up: chromeNeeds a response from a Chrome representativeNeeds a response from a Chrome representativeinconsistencyInconsistent behavior across browsersInconsistent behavior across browsersneeds-triage: chromeChrome needs to assess this issue for the first timeChrome needs to assess this issue for the first timeneeds-triage: firefoxFirefox needs to assess this issue for the first timeFirefox needs to assess this issue for the first timeneutral: safariNot opposed or supportive from SafariNot opposed or supportive from Safaritopic: eventsIssues related to the registration, management, and dispatch of WebExtension events.Issues related to the registration, management, and dispatch of WebExtension events.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Intro
Currently the persistence of
runtime.setUninstallURL()differs per browser:uninstallURLand requires it on every run of the background scriptuninstallURLeven after updateThis leads to the following issues:
uninstallURLwhen an extension is disabled beforehand (see Should disabled extensions have theirruntime.setUninstallURLopened on uninstall? #970)uninstallURL. If a developer wants to stop opening anuninstallURL, pushing an update without anuninstallURLwill not impact existing installations wheresetUninstallURL()is called.Orion seems to at least persist between browser sessions. However did not test if it is persisted on update.
Solution
All browsers persist the
uninstallURLUNTIL and excluding in the case of an extension update, resolving both issues.The only workaround right now in Chrome would be to use
runtime.setUninstallURL('')indefinitely if historically it used anuninstallURLyet nolonger wants this in newer versions.