Skip to content

Code suggestion #6

@osamuaoki

Description

@osamuaoki

I have been playing with your code a bit.

I see code as:

if options["dont_center"] then
    config["dont_center"] = options["dont_center"]
  end

Since dont_center has true/false value, what you want is more like:

if options["dont_center"] ~= nil then
    config["dont_center"] = options["dont_center"]
  end

The same is true for open_folds.

For ignore_*, they can be as you wrote. But for consistency and elegance, you may want to check against ~= nil.

Just a thought for better code.

My mod branch can be seen at: https://github.com/osamuaoki/remember.nvim/tree/osamu . This contains other mods which you may not agree and I don't know if I will be using in my future. So I am not requesting merge at this moment.

Thanks.

Osamu

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions