Skip to content

Commit cf2e1cf

Browse files
committed
change private ecr
1 parent f1571f0 commit cf2e1cf

1 file changed

Lines changed: 25 additions & 9 deletions

File tree

.github/workflows/docker-image.yml

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,35 @@ jobs:
2727
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
2828
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
2929
aws-region: ${{ env.AWS_REGION }}
30+
31+
####################################
3032

31-
- name: Login to Amazon ECR Public
32-
id: login-ecr-public
33+
- name: Login to Amazon ECR
34+
id: login-ecr
3335
uses: aws-actions/amazon-ecr-login@v2
34-
with:
35-
registry-type: public
3636

37-
- name: Build, tag, and push docker image to Amazon ECR Public
37+
- name: Build, tag, and push docker image to Amazon ECR
3838
env:
39-
REGISTRY: ${{ steps.login-ecr-public.outputs.registry }}
40-
REGISTRY_ALIAS: "329599632133.dkr.ecr.us-east-1.amazonaws.com"
39+
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
4140
REPOSITORY: "ascan"
4241
IMAGE_TAG: ${{ github.sha }}
4342
run: |
44-
docker build -t $REGISTRY/$REGISTRY_ALIAS/$REPOSITORY:$IMAGE_TAG .
45-
docker push $REGISTRY/$REGISTRY_ALIAS/$REPOSITORY:$IMAGE_TAG
43+
docker build -t $REGISTRY/$REPOSITORY:$IMAGE_TAG .
44+
docker push $REGISTRY/$REPOSITORY:$IMAGE_TAG
45+
46+
####################################
47+
# - name: Login to Amazon ECR Public
48+
# id: login-ecr-public
49+
# uses: aws-actions/amazon-ecr-login@v2
50+
# with:
51+
# registry-type: public
52+
53+
# - name: Build, tag, and push docker image to Amazon ECR Public
54+
# env:
55+
# REGISTRY: ${{ steps.login-ecr-public.outputs.registry }}
56+
# # REGISTRY_ALIAS: "329599632133.dkr.ecr.us-east-1.amazonaws.com"
57+
# REPOSITORY: "ascan"
58+
# IMAGE_TAG: ${{ github.sha }}
59+
# run: |
60+
# docker build -t $REGISTRY/$REGISTRY_ALIAS/$REPOSITORY:$IMAGE_TAG .
61+
# docker push $REGISTRY/$REGISTRY_ALIAS/$REPOSITORY:$IMAGE_TAG

0 commit comments

Comments
 (0)