Skip to content

Fix: Settings object should be directly used #13

@Parth971

Description

@Parth971

In core/app.py file, we are creating settings object again like

from core.config import Settings
settings = Settings()
kit = FastAppKit(settings=settings)
app = kit.create_app()

But instead, we should directly inport settings from config like

from core.config import settings
kit = FastAppKit(settings=settings)
app = kit.create_app()

Because it's already created object in core/config.py like

# Global settings instance
settings = Settings()

Same issues in

  • core/app.py
  • tests/test_config.py
  • core/db/migrations/env.py

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions