Skip to content

Docs/dashboard style updates#4255

Merged
ugur-vaadin merged 7 commits into
latestfrom
docs/dashboard-style-updates
May 22, 2025
Merged

Docs/dashboard style updates#4255
ugur-vaadin merged 7 commits into
latestfrom
docs/dashboard-style-updates

Conversation

@rolfsmeds
Copy link
Copy Markdown
Contributor

Dashboard docs updates for vaadin/web-components#8962

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2025

AI Language Review

In the JavaScript TypeScript code:

  1. In dashboard-basic and dashboard-dense-layout components, the updated version uses --vaadin-dashboard-widget-rowspan and --vaadin-dashboard-widget-colspan instead of --vaadin-dashboard-item-rowspan and --vaadin-dashboard-item-colspan. Ensure this change is intentional and consistent with any associated updates in vaadin-dashboard API.

  2. In the Styling AsciiDoc file, under the "Style Variants" section, ensure consistency with any related components or themes in the vaadin-dashboard API if applicable.

No major issues, just ensure compatibility with these changes in the broader application context.

@rolfsmeds rolfsmeds requested a review from jouni May 19, 2025 11:24
@ugur-vaadin ugur-vaadin force-pushed the docs/dashboard-style-updates branch from 3d4a848 to a86db94 Compare May 22, 2025 10:24
@ugur-vaadin ugur-vaadin merged commit 5d7dc25 into latest May 22, 2025
4 of 5 checks passed
@ugur-vaadin ugur-vaadin deleted the docs/dashboard-style-updates branch May 22, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants