Skip to content

Consistent artifact name check #89

@AB-xdev

Description

@AB-xdev

Currently the "artifact name check" is executed in some places and in others it is not.

This should be fixed.

Source: xdev-software/vaadin-addon-template#318

mstahv

"2025-04-24T08:48:41.265Z","logspout-logspout-288","website-directory-service","2025-04-24 08:48:41.264  INFO 1 --- [   scheduling-1] c.v.d.service.ComponentVersionPoller     : Uploading new version of LeafletMap for Vaadin (19552)."
"2025-04-24T08:48:41.289Z","logspout-logspout-288","website-directory-service","java.lang.IllegalStateException: Names don't match!"

So the groupId is fine in the system, there was just some "sanity check" that you can't change the addon suddenly to somethign completely different (or at least you need to still keep the name :-).

AB-xdev

Thank you for the detailed feedback and insight!

I find this behavior is a bit strange, because when I click "New version from Maven" this check isn't executed... There is also no information when creating a new component, that the maven pom name can't be changed (I expected it to only be used for initially importing the add-on):

Image

Once the name was set it can't be changed on Vaadin Directory anyway by the user so I see no point why the check is even needed in the first place. I think it would be best if the name check is removed in the future to prevent such confusing situations as the current one.

mstahv

The name check should indeed be either in both places or in none

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions