Skip to content

Commit bae3b17

Browse files
committed
Fix Monitor Start Argument Handling
1 parent cce5f4b commit bae3b17

2 files changed

Lines changed: 12 additions & 14 deletions

File tree

Monitor/trunk/src/org/tzi/use/plugins/monitor/cmd/StartMonitorCmd.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.tzi.use.plugins.monitor.MonitorPlugin;
55
import org.tzi.use.plugins.monitor.vm.adapter.InvalidAdapterConfiguration;
66
import org.tzi.use.plugins.monitor.vm.adapter.VMAdapter;
7+
import org.tzi.use.plugins.monitor.vm.adapter.jvm.JVMAdapter;
78
import org.tzi.use.util.Log;
89
import org.tzi.use.util.StringUtil;
910

@@ -12,26 +13,23 @@ public class StartMonitorCmd extends AbstractMonitorCmd {
1213
@Override
1314
public void doPerformCommand(IPluginShellCmd pluginCommand) {
1415
if (MonitorPlugin.getInstance().getMonitor().isRunning()) {
15-
Log.error("Already monitioring an application. Please stop before starting a new monitor.");
16+
Log.error("Already monitoring an application. Please stop before starting a new monitor.");
1617
return;
1718
}
1819

19-
String[] args = pluginCommand.getCmdArguments().split(" ");
20-
20+
String[] args = pluginCommand.getCmdArgumentList();
21+
String adapterName;
2122
if (args.length == 0) {
23+
adapterName = JVMAdapter.JVM_ADAPTER_NAME;
2224
Log.println("Using default value for JVM remote debugger: localhost:6000");
23-
}
24-
25-
String adpaterName = args[0];
26-
VMAdapter adapter = MonitorPlugin.getInstance().getAdapterRegistry().getAdapterByName(adpaterName);
25+
} else {
26+
adapterName = args[0];
27+
}
2728

29+
VMAdapter adapter = MonitorPlugin.getInstance().getAdapterRegistry().getAdapterByName(adapterName);
2830
if (adapter == null) {
29-
Log.print("Invalid adapter name " + StringUtil.inQuotes(adpaterName) + " specified.");
31+
Log.println("Invalid adapter name " + StringUtil.inQuotes(adapterName) + " specified.");
3032
return;
31-
}
32-
33-
for (int i = 1; i < args.length;++i) {
34-
3533
}
3634

3735
try {
@@ -41,6 +39,4 @@ public void doPerformCommand(IPluginShellCmd pluginCommand) {
4139
}
4240
}
4341

44-
45-
4642
}

Monitor/trunk/src/org/tzi/use/plugins/monitor/vm/adapter/jvm/JVMAdapter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@
8181
*/
8282
public class JVMAdapter extends AbstractVMAdapter {
8383

84+
public static final String JVM_ADAPTER_NAME = "JVMAdapter";
85+
8486
private static final int SETTING_HOST = 0;
8587

8688
private static final int SETTING_PORT = 1;

0 commit comments

Comments
 (0)