docs,examples: standardize KIS_ACCOUNT_NUMBER → KIS_ACCOUNT_NO + KIS_ACCOUNT_CODE#35
Merged
Merged
Conversation
…ACCOUNT_CODE v1.7.0 환경변수 표준화 후속 정리. docs와 examples에 남아있던 비표준 환경변수 KIS_ACCOUNT_NUMBER(합본 "12345678-01" 형식)를 표준 KIS_ACCOUNT_NO + KIS_ACCOUNT_CODE 분리 형식으로 통일. 같이 정리한 outdated API 호출: - KISClient(account_number=..., is_real=True) — 실제 시그니처와 불일치 → KISClient(config=KISConfig(account_no=..., account_code=..., base_url=...)) - account_number[:8]/[8:] 슬라이싱 hack 제거 - getting-started.md의 잘못된 메서드 예제(get_access_token, get_daily_price)를 실제 Agent 파사드 API(agent.get_stock_price, agent.inquire_daily_itemchartprice)로 교체 영향: docs/guides/getting-started.md, docs/api/websocket-api.md, examples/websocket_multi_subscribe.py, examples/export_trading_history.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.7.0 환경변수 표준화(PR #33)의 후속 정리. docs/examples에 남아있던 비표준 환경변수
KIS_ACCOUNT_NUMBER(합본 "12345678-01" 형식)를 표준KIS_ACCOUNT_NO+KIS_ACCOUNT_CODE분리 형식으로 통일.Changes
docs/guides/getting-started.md: env 예제 + Agent 파사드 사용법으로 재작성docs/api/websocket-api.md: KISClientaccount_number=→KISConfig(account_no=, account_code=)examples/websocket_multi_subscribe.py: outdated KISClient 시그니처 수정 + KIS_ACCOUNT_NO/CODE 분리examples/export_trading_history.py: 동일하게 표준화, MOCK_BASE_URL 상수 사용같이 정리한 outdated API 호출
코드와 일치하지 않던 docs/examples를 실제 시그니처로 맞춤:
KISClient(account_number=..., is_real=True)KISClient(config=KISConfig(account_no=..., account_code=..., base_url=...))account_number[:8]/account_number[8:]get_access_token,get_daily_priceagent.get_stock_price,agent.inquire_daily_itemchartprice)로 교체Test plan
python -m py_compile두 examples 통과KIS_ACCOUNT_NUMBER/account_number=잔존 검색 0건