From c7479a14fd6e37f3e42587a89436941bb515e00d Mon Sep 17 00:00:00 2001 From: Daniel Perrett Date: Thu, 16 Oct 2025 10:41:54 +0100 Subject: [PATCH 01/21] chore: remove redundant nomenclature_notification code https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/348 --- .../taxon_concept_controller.js.coffee | 4 - .../species/models/taxon_concept.js.coffee | 1 - .../species/templates/_tabs.handlebars | 9 -- .../nomenclature_changes_notification.scss | 13 --- .../species/show_taxon_concept_serializer.rb | 21 +---- .../api/taxon_concepts_controller_spec.rb | 1 - .../show_taxon_concept_serializer_spec.rb | 87 +------------------ 7 files changed, 2 insertions(+), 134 deletions(-) delete mode 100644 app/assets/stylesheets/species/nomenclature_changes_notification.scss diff --git a/app/assets/javascripts/species/controllers/taxon_concept_controller.js.coffee b/app/assets/javascripts/species/controllers/taxon_concept_controller.js.coffee index c36238569..496512aec 100644 --- a/app/assets/javascripts/species/controllers/taxon_concept_controller.js.coffee +++ b/app/assets/javascripts/species/controllers/taxon_concept_controller.js.coffee @@ -255,10 +255,6 @@ Species.TaxonConceptController = Ember.ObjectController.extend Species.SearchCon if @get('nomenclatureNoteEn') == null || @get('nomenclatureNoteEn').length <= 0 then no else yes ).property('nomenclatureNoteEn') - nomenclatureChangesHappened: ( -> - @get('nomenclatureNotification') - ).property('nomenclatureNotification') - actions: openSearchPage: (taxonFullName) -> @get("controllers.search").openSearchPage taxonFullName diff --git a/app/assets/javascripts/species/models/taxon_concept.js.coffee b/app/assets/javascripts/species/models/taxon_concept.js.coffee index 4fe14a219..7af123bfb 100644 --- a/app/assets/javascripts/species/models/taxon_concept.js.coffee +++ b/app/assets/javascripts/species/models/taxon_concept.js.coffee @@ -31,7 +31,6 @@ Species.TaxonConcept = DS.Model.extend nomenclatureNoteEn: DS.attr("string") nomenclatureNoteFr: DS.attr("string") nomenclatureNoteEs: DS.attr("string") - nomenclatureNotification: DS.attr("boolean") matchingNamesForDisplay: ( -> if @get('matchingNames') != undefined && @get('matchingNames').length > 0 diff --git a/app/assets/javascripts/species/templates/_tabs.handlebars b/app/assets/javascripts/species/templates/_tabs.handlebars index dd6fa8448..c2332c334 100644 --- a/app/assets/javascripts/species/templates/_tabs.handlebars +++ b/app/assets/javascripts/species/templates/_tabs.handlebars @@ -1,12 +1,3 @@ -{{#if nomenclatureChangesHappened}} - -{{/if}} -