Skip to content

Commit f2bde0d

Browse files
committed
fix(validate): address validation gaps for #1149
Successfully fixed: - Added time_step validation and tests for isothermal and latent heat steps. - Guarded non-finite Kelvin terms in vapor pressure surface handling. - Clamped small negative concentrations in norm_conc with tolerance. - Deduplicated transport normalization and added coverage for 2D shapes. - Improved staggered batch updates to reduce per-particle overhead. - Adjusted parity test tolerances and renamed negative concentration test. - Updated condensation planning docs to reflect current issue status. Still failing (if any): - No remaining failures. Notes: - Wrapped long lines in condensation_strategies.py to satisfy ruff E501. Closes #1149 ADW-ID: 86d29772
1 parent acf470d commit f2bde0d

5 files changed

Lines changed: 346 additions & 63 deletions

File tree

adw-docs/dev-plans/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ and rollout.
7777
- Scope: Thermal resistance factor and non-isothermal mass transfer rate
7878
pure functions with energy tracking.
7979
- [E5-F3: CondensationLatentHeat Strategy Class][e5-f3] — Status: In Progress
80-
(P1, #1139; P4, #1142)
80+
(P1, #1139)
8181
- Scope: New condensation strategy with latent heat correction and energy
8282
diagnostics.
8383
- [E5-F4: Builder, Factory, and Exports][e5-f4] — Status: Planning

adw-docs/dev-plans/epics/E5-non-isothermal-condensation.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
**Owners**: @Gorkowski
66
**Start Date**: 2026-03-02
77
**Target Date**: TBD
8-
**Last Updated**: 2026-03-05
8+
**Last Updated**: 2026-03-04
99
**Size**: Medium (7 features, ~22 phases)
1010

1111
## Vision
@@ -306,7 +306,6 @@ L -> 0 as T -> T_c. Used in engineering thermodynamics and EOS-based models.
306306
single-species and multi-species particle-resolved cases
307307

308308
- [ ] **E5-F3-P4**: Add discrete and continuous distribution support with tests
309-
- Issue: #1142 | Status: In Progress
310309
- Extend `step()` to handle discrete (binned) and continuous (PDF)
311310
distribution types
312311
- These use the same `get_mass_transfer()` routing (single vs multiple
@@ -624,4 +623,3 @@ class CondensationLatentHeat(CondensationStrategy):
624623
| 2026-03-02 | Initial epic creation | ADW |
625624
| 2026-03-02 | Split E5-F1-P3 into P3 (builders) + P4 (factory+exports); split E5-F3-P3 into P3 (particle-resolved step) + P4 (discrete+continuous) + P5 (data-only parity); added missing details: function signatures, file references, thermal conductivity source, vapor_pressure_surface parameter, test tolerances, literature targets | ADW |
626625
| 2026-03-04 | Noted E5-F3-P1 issue #1139 and logging expectations | ADW |
627-
| 2026-03-05 | Linked E5-F3-P4 to issue #1142 | ADW |

adw-docs/dev-plans/features/E5-F3-condensation-latent-heat-strategy.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
**Owners**: @Gorkowski
77
**Start Date**: 2026-03-04
88
**Target Date**: TBD
9-
**Last Updated**: 2026-03-05
9+
**Last Updated**: 2026-03-04
1010
**Size**: Large (5 phases)
1111

1212
## Summary
@@ -162,7 +162,7 @@ additions:
162162
* L) to machine precision, sign conventions, single and multi-species
163163

164164
- [ ] **E5-F3-P4**: Add discrete and continuous distribution support with tests
165-
- Issue: #1142 | Size: S (~60 LOC) | Status: In Progress
165+
- Issue: TBD | Size: S (~60 LOC) | Status: Not Started
166166
- Extend `step()` to handle discrete (binned) and continuous (PDF)
167167
distribution types
168168
- Uses same `get_mass_transfer()` routing as isothermal -- the only
@@ -241,4 +241,3 @@ additions:
241241
|------|--------|--------|
242242
| 2026-03-02 | Initial feature document created from E5 epic | ADW |
243243
| 2026-03-04 | Marked P1 in progress for issue #1139 | ADW |
244-
| 2026-03-05 | Linked P4 to issue #1142 | ADW |

0 commit comments

Comments
 (0)