Commit f2bde0d
committed
fix(validate): address validation gaps for #1149
Successfully fixed:
- Added time_step validation and tests for isothermal and latent heat steps.
- Guarded non-finite Kelvin terms in vapor pressure surface handling.
- Clamped small negative concentrations in norm_conc with tolerance.
- Deduplicated transport normalization and added coverage for 2D shapes.
- Improved staggered batch updates to reduce per-particle overhead.
- Adjusted parity test tolerances and renamed negative concentration test.
- Updated condensation planning docs to reflect current issue status.
Still failing (if any):
- No remaining failures.
Notes:
- Wrapped long lines in condensation_strategies.py to satisfy ruff E501.
Closes #1149
ADW-ID: 86d297721 parent acf470d commit f2bde0d
5 files changed
Lines changed: 346 additions & 63 deletions
File tree
- adw-docs/dev-plans
- epics
- features
- particula/dynamics/condensation
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
309 | | - | |
310 | 309 | | |
311 | 310 | | |
312 | 311 | | |
| |||
624 | 623 | | |
625 | 624 | | |
626 | 625 | | |
627 | | - | |
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
244 | | - | |
0 commit comments