Bug: `exclude-file-docstrings` not excluding files it should exclude.

[hu3bi]

This option is not working as intended:

Calling
go tool nilaway -exclude-file-docstrings 'Code generated by' ./...
or
go tool nilaway -exclude-file-docstrings="Code generated by" ./...

should exclude the following myFilename_templ.go file:

// Code generated by templ - DO NOT EDIT.

// templ: version: v0.3.1001
package component
…

However, this is not the case.

[yuxincs]

When we added templ support back then we kinda bypassed this, since templ generated files are a bit special: they are basically source files disguised as autogenerated files. When NilAway analyzes these generated files, we actually post the diagnostics back to the .templ source files.

Is that not the expected behavior? curious to learn if you'd actually want to ignore all templ files instead.

[hu3bi]

@yuxincs That makes sense. However for me, it was still unexpected, since I expected nilaway to be dumb and not aware that this is a file generated by templ and thus treat it different.

So calling
go tool nilaway -exclude-file-docstrings="Code generated by" ./...
I would expect to exclude all files which contain Code generated by .

Basic templ without go in the .templ sometimes produced false positives for me.

---

tldr:
@yuxincs what you wrote makes total sense. I expected nilaway to just dumbly follow instructions.

In the same way if I execute rm -rf / I would expect it to wipe my system.
Yes, I would never want to execute this command, but if my os would prevent me from calling it, it should at least let me know.