Redundant aria-labelledby

[andrewcroce]

After doing a bit more research about this, it seems the regular html <label> is sufficient for an accessible label. Adding this aria attribute might be more confusing than helpful.

Maybe this is already possible, but the only time you'd want it is if the normal label is not used. One should be able to manually add aria-label or aria-labelledby if they don't use the normal label.

https://github.com/promptworks/inputs/blob/4dca17868278b8fd7de1773930754c7239ccc1f2/src/useFieldProps.ts#L69

[rzane]

Would you be open to submitting a PR to fix this?

[andrewcroce]

Uhhh, I'm not sure i know how. I'm honored you have this confidence in me @rzane

[andrewcroce]

Actually, seems like its simpler than I thought... just remove that line, no?? And maybe the id in getLabelProps is redundant?

Took me a sec to wrap my head around how useFieldProps works.

[rzane]

Yeah, that'd probably do it. You'll probably have to update the snapshots as well.

Also, we'll want to double check that aria-labelledby can be passed through to the input, but I don't think that'll require any changes.

[andrewcroce]

Yeah I just tested that on the StackupUI demo. An arbitrary "aria-label" is rendered correctly on the input, so I assume that means any additional props are just passed down.