ZJIT: Add IseqVersion::is_invalidated() method

Address review feedback: use a method instead of directly comparing
.status == IseqStatus::Invalidated.

Author: k0kubun

zjit/src/codegen.rs

@@ -222,7 +222,7 @@ fn gen_iseq_entry_point(cb: &mut CodeBlock, iseq: IseqPtr, jit_exception: bool)
 /// GC) so that all compile/recompile tuning decisions live in one place.
 pub fn invalidate_iseq_version(cb: &mut CodeBlock, iseq: IseqPtr, version: &mut IseqVersionRef) {
     let payload = get_or_create_iseq_payload(iseq);
-    if unsafe { version.as_ref() }.status != IseqStatus::Invalidated
+    if !unsafe { version.as_ref() }.is_invalidated()
         && payload.versions.len() < max_iseq_versions()
     {
         unsafe { version.as_mut() }.status = IseqStatus::Invalidated;
@@ -3055,7 +3055,7 @@ c_callable! {
             let iseq: IseqPtr = iseq_raw.as_iseq();
             let payload = get_or_create_iseq_payload(iseq);
             let already_done = payload.versions.last()
-                .map_or(false, |v| unsafe { v.as_ref() }.status == IseqStatus::Invalidated)
+                .map_or(false, |v| unsafe { v.as_ref() }.is_invalidated())
                 || payload.versions.len() >= max_iseq_versions();
             if already_done {
                 return;

zjit/src/hir.rs

@@ -7,7 +7,7 @@
 #![allow(clippy::match_like_matches_macro)]
 use crate::{
     backend::lir::C_ARG_OPNDS,
-    cast::IntoUsize, codegen::{local_idx_to_ep_offset, max_iseq_versions}, cruby::*, invariants::{self}, payload::{get_or_create_iseq_payload, IseqPayload, IseqStatus}, options::{debug, get_option, DumpHIR}, state::ZJITState, json::Json,
+    cast::IntoUsize, codegen::{local_idx_to_ep_offset, max_iseq_versions}, cruby::*, invariants::{self}, payload::{get_or_create_iseq_payload, IseqPayload}, options::{debug, get_option, DumpHIR}, state::ZJITState, json::Json,
     state,
 };
 use std::{
@@ -2446,7 +2446,7 @@ impl CompilePolicy {
         } else {
             let payload = get_or_create_iseq_payload(iseq);
             payload.versions.iter().any(
-                |v| unsafe { v.as_ref() }.status == IseqStatus::Invalidated
+                |v| unsafe { v.as_ref() }.is_invalidated()
             ) && payload.versions.len() + 1 >= max_iseq_versions()
         };
         Self { no_side_exits }

zjit/src/payload.rs

@@ -51,6 +51,11 @@ pub struct IseqVersion {
 pub type IseqVersionRef = NonNull<IseqVersion>;
 
 impl IseqVersion {
+    /// Check if this version was invalidated
+    pub fn is_invalidated(&self) -> bool {
+        self.status == IseqStatus::Invalidated
+    }
+
     /// Allocate a new IseqVersion to be compiled
     pub fn new(iseq: IseqPtr) -> IseqVersionRef {
         let version = Self {