Fix/9 architecture#10
Open
tulashvili wants to merge 12 commits into
Open
Conversation
NovikovDavid
reviewed
Feb 2, 2026
| import "errors" | ||
|
|
||
| // Validate user answer | ||
| func ValidateAnswer(answer int) error { |
Collaborator
There was a problem hiding this comment.
Сделать его методом для UserAnswer, вынести его в файл answer.go
| "fmt" | ||
| "time" | ||
| type Question struct { | ||
| Category |
|
|
||
| "github.com/tulashvili/MyDailyControlQuestions/internal/models" | ||
| ) | ||
| type Category string |
Comment on lines
+21
to
+24
| query := ` | ||
| INSERT INTO daily_log (category, question, answer, answeredAt) | ||
| VALUES (?, ?, ?, ?) | ||
| ` |
Collaborator
There was a problem hiding this comment.
переписать под sqlx и почитай про sql инъекции
Comment on lines
+1
to
+8
| package repo | ||
|
|
||
| import "github.com/tulashvili/MyDailyControlQuestions/internal/domain" | ||
|
|
||
| type AnswerRepository interface { | ||
| SaveAnswer(answer domain.UserAnswer) error | ||
| GetAnswers(period int) ([]domain.UserAnswer, error) | ||
| } |
Collaborator
There was a problem hiding this comment.
тут это не нужно, за хорошую практику считается использовать интерфейсы в месте использования
| "github.com/tulashvili/MyDailyControlQuestions/internal/usecase" | ||
| ) | ||
|
|
||
| var listQuestionsCmd = &cobra.Command{ |
Collaborator
There was a problem hiding this comment.
лучше в один файл вынести все команды
| Long: ``, | ||
| } | ||
|
|
||
| func Execute(conn *sql.DB) { |
Collaborator
There was a problem hiding this comment.
зачем сюда конект прокидываешь?
| db *sql.DB | ||
| } | ||
|
|
||
| func NewSQLiteAnswerRepository(db *sql.DB) *SQLiteAnswerRepository { |
Collaborator
There was a problem hiding this comment.
убери из названия SQLite
|
|
||
| // ToDo: move this to migrate.go | ||
|
|
||
| func InitDB(path db.DataSource) (*sql.DB, error) { |
Collaborator
There was a problem hiding this comment.
удалить это все, переписать миграции под goose, конект вынести в db.go
|
|
||
| if err := sqlitedb.CreateTable(app.DB); err != nil { | ||
| log.Fatal(err) | ||
| } |
Collaborator
There was a problem hiding this comment.
а где все остальное? слой репозитория, сервисный слой и т.д
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.