Skip to content

Previous PR comment loose ends #573

@jtlangevin

Description

@jtlangevin

For PR #564:

  • @rHorsey We should also check the impact of try/except vs .get in the profilers. It should matter with memory but may with runtime. I prefer the .get syntax from an intent perspective but the comments make that just a preference.

For PR #565:

For #532:

Break up the apply_incentives function: #532 (comment)
Use dicts or data class to handle key parameters of state-level drivers (note that this applies to other PRs that involve import of state-level drivers:
#532 (comment)
#532 (comment)

For #534:

Consider existing comments about trim_results option in #505: #534 (comment)
Create separate module/py file to handle BPS and codes: #534 (comment)
Use variables instead of dict lookups for deeply nested logic #534 (comment)
Is there a better way to pass through code/BPS inputs with so many similar variable names that are hard to track? #534 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions