Skip to content

chore: add bridge param to recursive matching calls#1303

Merged
MicBun merged 1 commit into
mainfrom
addparamagain
Jan 24, 2026
Merged

chore: add bridge param to recursive matching calls#1303
MicBun merged 1 commit into
mainfrom
addparamagain

Conversation

@MicBun
Copy link
Copy Markdown
Contributor

@MicBun MicBun commented Jan 24, 2026

resolves: https://github.com/truflation/website/issues/2979

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved order book matching to correctly handle bridge context during sequential matching operations, enhancing accuracy and consistency across all matching stages.

✏️ Tip: You can customize this high-level summary in your review settings.

@MicBun MicBun self-assigned this Jan 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

These changes thread a bridge parameter through recursive calls in the order book matching functions and update a test extension name reference for market query creation.

Changes

Cohort / File(s) Summary
Order Book Matching Logic
internal/migrations/032-order-book-actions.sql
Updated three recursive functions—match_direct, match_mint, and match_burn—to pass the bridge parameter through their recursive invocations, enabling bridge context to persist deeper in the matching recursion.
Order Book Tests
tests/streams/order_book/queries_test.go
Changed the extension name argument in createTestMarketQueries from testExtensionName to testExtensionNameQueries for the "create_market" action.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • pr-time-tracker

Poem

🐰 Through recursion's depths, the bridge now flows,
Each matching call the context knows,
A thread of data, hand in hand,
The market logic, carefully planned! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main functional change: adding a bridge parameter to recursive matching function calls across three functions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@holdex
Copy link
Copy Markdown

holdex Bot commented Jan 24, 2026

Time Submission Status

Member Status Time Action Last Update
MicBun ✅ Submitted 1h Update time Jan 24, 2026, 12:02 AM

You can submit time with the command. Example:

@holdex pr submit-time 15m

See available commands to help comply with our Guidelines.

@MicBun MicBun merged commit ac006ed into main Jan 24, 2026
7 of 8 checks passed
@MicBun MicBun deleted the addparamagain branch January 24, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant